Everything I know about Code Reviews I learnt from Star Wars (and JCooney)
secretGeek .:dot Nuts about dot Net:.
home .: about .: sign up .: sitemap .: secretGeek RSS

Everything I know about Code Reviews I learnt from Star Wars (and JCooney)

Imagine you're on a project where Joseph Cooney performs code reviews on everything you try to check in...just theoretically. And, theoretically, people like Don Syme and Joel Pobar are on hand to provide useful feedback at times...

Many many iterations ago... in a project far, far away...


Joseph (in red, indented)Leon (in blue)
Aren't you a little short for a developer?Don't underestimate the Force.You may dispense with the pleasantries, Bambrick. I'm here to put you back on schedule.So, can I can check it in? You like my code?You'll never find a more wretched hive of scum and villainy.We must be cautious.What's that line of code there?It's an old code, but it checks out. I was about to check it in.Does it compile?I find your lack of faith disturbing.

This part uses composition. The weapon of a true coder. Not as clumsy or random as code generation or polymorphism; an elegant design pattern for a more civilized age.Don't be too proud of this technological terror you've constructed. The power to destroy performance is insignificant compared to the power of an enterprise rules engine.We shall re-double our efforts...I hope so bambrick for your sake. The build master is not as forgiving as I am.Look, Your Worshipfulness, let's get one thing straight. I take orders from just one person: meIt's a wonder you're still alive.It's a valid implementation. Screaming about it won't help you.Let 'em defect it. It is not wise to upset a tester.But Joe, nobody worries about upsetting a developer.That's 'cause devs don't pull people's arms out of their sockets when they lose. Testers are known to do that.Wonderful girl. Either I'm going to kill her or I'm beginning to like her.So I'll check it in?I have a very bad feeling about this...[pauses]

It's a TRAP... err CRAPDamn fool, I knew you were going to say that.Your insight serves you well. Bury your feelings deep down, LB. They do you credit, but they could be made to serve the rules engine.

You can write this shit LB, but that doesn't mean we can checkit in.

Last resort: use Jedi mind tricks on Joseph:

These are not the bugs you're looking for (wave hands)These are not the bugs we're looking for.
You may go about your business. Check it in.

(that's a fairly typical back and forth).


'Dom' on Sun, 13 Apr 2008 22:24:01 GMT, sez:

Damn it- you're a funny bugger Leon.


'madonna' on Tue, 15 Apr 2008 19:14:37 GMT, sez:

ha-ha-ha!!! that's funny :)


Add your comment.


name


website (optional)


enter the word:
 

comment (HTML not allowed)


All viewpoints welcome. But the right to delete any post for any reason is reserved. Don't make me do it. Comments may be republished, emailed to your loved ones or printed and used as toilet paper. Who reads this legal bit anyhow?

TimeSnapper is a life analysis system that stores and plays-back your computer use. It makes timesheet recording a breeze, helps you recover lost work and shows you how to sharpen your act.

TimeSnapper won last year's Developer Competition at Larkware.com, and is used by over 10,000 people.

Articles

What To (Really) Do If You Find Out Your Parents Are Using Vista (redux) What To (Really) Do If You Find Out Your Parents Are Using Vista (redux)
What To Do If You Find Out Your Parents Are Using Vista What To Do If You Find Out Your Parents Are Using Vista
Sample Code From Text-Adventure Game Platforms Sample Code From Text-Adventure Game Platforms
TimeSnapper 3.0 -- an interactive, bubbling cauldron of possibilities TimeSnapper 3.0 -- an interactive, bubbling cauldron of possibilities
The laptop compubody sock The laptop compubody sock
Everything that's bad for you is suddenly good for you! Everything that's bad for you is suddenly good for you!
Everything I know about Code Reviews I learnt from Star Wars (and JCooney) Everything I know about Code Reviews I learnt from Star Wars (and JCooney)
Syntax highlighting of strings Syntax highlighting of strings
Google AppEngine: evil virus or viral evil? Google AppEngine: evil virus or viral evil?
Workflow software: I'm calling the bluff. Workflow software: I'm calling the bluff.
Archives .: secretGeek :: Complete Archives :.
25 steps for building a Micro-ISV 25 steps for building a Micro-ISV
3 minute guides -- babysteps in new technologies: powershell, JSON, watir, F# 3 Minute Guide Series
Top 10 SecretGeek articles Top 10 SecretGeek articles

Downloads

TimeSnapper -- Automated Screenshot Journal TimeSnapper.com    
Version 2.5: with password protection
ShinyPower (help with Powershell) ShinyPower
Now at CodePlex
Next Action NextAction
Managing the top of your mind

[powered by Google] 
Thai Erawan, Brisbane Restaurant, delicious thai food in paddington Thai Erawan, Brisbane Restaurant
World's Simplest Code Generator (html edition) World's Simplest Code Generator
Gradient Maker -- a tool for making background images that blend from one colour to another. Forget photoshop, this is the bomb. Gradient Maker
How to be depressed How to be depressed
You are not inadequate.

Recommended Reading

The Best Software Writing I
The Business Of Software (Eric Sink)

Recommended blogs

Jeff Atwood
Reginald Braithwaite
Joseph Cooney
Phil Haack
Scott Hanselman
Julia Lerman
Joel Pobar
Eric Sink
Joel Spolsky
Des Traynor

Aggregated Links

programming.reddit.com
dzone
dot net kicks

Human Link Machines

interesting finds
a continuous learner's weblog
arjan's world
n links today
new and notable
morning coffee
learning .net
weekly link post
(my del.icio.us account)
LinkedIn profile

.: bookmark this page at del.icio.us bookmark at Del.icio.us! :: reddit this reddit this :.

 
home .: about .: sign up .: sitemap .: secretGeek RSS .: © Leon Bambrick 2006 .: privacy

home .: about .: sign up .: sitemap .: RSS .: © Leon Bambrick 2006 .: privacy